Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply ButtonIcon component #2679

Merged

Conversation

tiagoalvesdulce
Copy link
Member

Dependencies

Depends on decred/pi-ui#405

UI Changes Screenshot

Light theme

Screen Shot 2021-11-29 at 16 54 35

Screen Shot 2021-11-29 at 16 53 02

Screen Shot 2021-11-29 at 16 47 23

Dark theme

Screen Shot 2021-11-29 at 17 18 27

Screen Shot 2021-11-29 at 17 18 35

Screen Shot 2021-11-29 at 17 18 48

Screen Shot 2021-11-29 at 17 19 09

Copy link
Member

@victorgcramos victorgcramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good Job! Once you upgrade pi-ui, it should be good to go!

@tiagoalvesdulce
Copy link
Member Author

Removing node v15.x support is needed to upgrade pi-ui at the moment and node v15.x isn't LTS. As soon as we get decred/pi-ui#418 merged we can add node v16.x support.

@tiagoalvesdulce
Copy link
Member Author

@lukebp this one is ready.

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tiagoalvesdulce tiagoalvesdulce merged commit 701eb18 into decred:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants