Use Go 1.24 module tool directives #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer necessary to keep track of the executables with blank imports in source files ignored with build tags.
davecgh
approved these changes
Feb 12, 2025
davecgh
reviewed
Feb 12, 2025
| @@ -2,7 +2,7 @@ module decred.org/release/v2/dcrctl | |||
|
|
|||
| go 1.17 | |||
There was a problem hiding this comment.
Well, I approved it already, but now I'm wondering if this needs to be go1.24 for the tool directive (and same with the others). It works fine with a go.work which requires go1.24, but without it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer necessary to keep track of the executables with blank imports in source files ignored with build tags.