fix: race condition on webrtc handler #496
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #497
Problem
My product is React WebAPP for GIS system, I use RTSPtoWeb as Media Server. My product's users sometimes create & close webrtc players in very short time.
When there are many traffics, I found some of cameras does not release its RTSP Connection with RTSPtoWeb server.
I fixed it and worked well in my product.
gin.Context Is Not Concurrency-Safe
gin.Context is not created each requests. Gin uses sync.Pool. so if there are many traffics, sometimes race condition happens.
you should use Copy method or just store params on new variables.
or