Skip to content

Re-implement ParallelWhere using JobScheduler semantics. #8086

Re-implement ParallelWhere using JobScheduler semantics.

Re-implement ParallelWhere using JobScheduler semantics. #8086

Triggered via pull request January 12, 2024 00:10
Status Failure
Total duration 1m 38s
Artifacts

quick-ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 1 warning
quick
Execution failed for task ':engine-table:spotlessJavaCheck'. > The following files had format violations: src/main/java/io/deephaven/engine/table/impl/AbstractFilterExecution.java @@ -93,8 +93,7 @@ ········WritableRowSet·addedResult; ········WritableRowSet·modifyResult; -········FilterExecutionContext()·{ -········} +········FilterExecutionContext()·{} ········@OverRide ········public·void·close()·{ @@ -103,10 +102,10 @@ ········public·void·reset()·{ ············//·TODO:·having·basePerformanceEntry·as·final·and·calling·BasePerformanceEntry#baseEntryReset()·would·be -············//··better,·but·it's·package-private.·Can·we·expose·it? +············//·better,·but·it's·package-private.·Can·we·expose·it? ············basePerformanceEntry·=·new·BasePerformanceEntry(); ············try·(final·SafeCloseable·ignored1·=·addedResult; -·················final·SafeCloseable·ignored2·=·modifyResult)·{ +····················final·SafeCloseable·ignored2·=·modifyResult)·{ ················addedResult·=·null; ················modifyResult·=·null; ············} @@ -115,7 +114,7 @@ ····/** ·····*·Run·the·single·filter·specified·by·this·AbstractFilterExecution·and·store·the·results·in·addedResult·and -·····*·modifyResult.··Allows·specification·of·the·start·and·end·positions·in·the·added·and·modified·inputs. +·····*·modifyResult.·Allows·specification·of·the·start·and·end·positions·in·the·added·and·modified·inputs. ·····* ·····*·@param·context·the·context·to·use·for·this·filter·to·accumulate·results·and·performance·data ·····*·@param·filter·the·filter·to·execute @@ -148,7 +147,8 @@ ················} ············} ············if·(modifiedInputToUse·!=·null)·{ -················try·(final·RowSet·processModifies·=·modifiedInputToUse.subSetByPositionRange(modifiedStart,·modifiedEnd))·{ +················try·(final·RowSet·processModifies·= +························modifiedInputToUse.subSetByPositionRange(modifiedStart,·modifiedEnd))·{ ····················context.modifyResult·=·filter.filter( ····························processModifies,·sourceTable.getRowSet(),·sourceTable,·usePrev); ················} Run './gradlew :engine-table:spotlessApply' to fix these violations.
quick
Gradle Build Scan: https://gradle.com/s/xbgrnj3di2skk