Skip to content

Commit

Permalink
build: Add provenence flag when publishing jsapi-types (#5204)
Browse files Browse the repository at this point in the history
- .npmrc file is not getting used with how we publish (building the tarball first and then publishing from a different directory)
- Adding the --provenance flag should generate the provenance statements automatically: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions
- This _should_ work even publishing from the tarball, as the provenance info is generated after the tarball is created: https://github.com/npm/provenance?tab=readme-ov-file#demo-generating-signed-slsa-provenance
  • Loading branch information
mofojed authored Mar 6, 2024
1 parent b01510b commit 1c1b4b2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ jobs:
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
env:
NODE_AUTH_TOKEN: ${{ secrets.DEEPHAVENBOT_NPM_TOKEN }}
run: npm publish --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz
run: npm publish --provenance --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz
continue-on-error: true
1 change: 0 additions & 1 deletion web/client-api/types/.npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
engine-strict=true
provenance=true

0 comments on commit 1c1b4b2

Please sign in to comment.