Remaining comments

deephaven · Nov 22, 2023 · 6b4aa24 · 6b4aa24
1 parent 405a679
commit 6b4aa24
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/extensions/parquet/base/src/main/java/io/deephaven/parquet/base/ColumnChunkReaderImpl.java b/extensions/parquet/base/src/main/java/io/deephaven/parquet/base/ColumnChunkReaderImpl.java
@@ -266,12 +266,11 @@ public ColumnPageReader next() {
                         throw new UncheckedDeephavenException(
                                 "Unknown parquet data page header type " + pageHeader.type);
                 }
-                if ((encoding == PLAIN_DICTIONARY || encoding == RLE_DICTIONARY)
-                        && dictionarySupplier.get() == NULL_DICTIONARY) {
-                    throw new ParquetDecodingException("Error in decoding page because dictionary data not found for " +
-                            " column " + path + " with encoding " + encoding);
-                }
-                return new ColumnPageReaderImpl(channelsProvider, decompressor, dictionarySupplier,
+                final Supplier<Dictionary> pageDictionarySupplier =
+                        (encoding == PLAIN_DICTIONARY || encoding == RLE_DICTIONARY)
+                                ? dictionarySupplier
+                                : () -> NULL_DICTIONARY;
+                return new ColumnPageReaderImpl(channelsProvider, decompressor, pageDictionarySupplier,
                         nullMaterializerFactory, path, getFilePath(), fieldTypes, readChannel.position(), pageHeader,
                         ColumnPageReaderImpl.NULL_NUM_VALUES);
             } catch (IOException e) {