Skip to content

Commit

Permalink
Addressed reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
chipkent committed Jan 10, 2024
1 parent a22292d commit 8ba59b4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1503,33 +1503,33 @@ public void testMinusNonBusinessDays() {
}

public void testFutureBusinessDate() {
assertEquals(bCalendar.plusBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), 3),
assertEquals(bCalendar.plusBusinessDays(bCalendar.calendarDate(), 3),
bCalendar.futureBusinessDate(3));
assertEquals(bCalendar.plusBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), -3),
assertEquals(bCalendar.plusBusinessDays(bCalendar.calendarDate(), -3),
bCalendar.futureBusinessDate(-3));
assertNull(bCalendar.futureBusinessDate(NULL_INT));
}

public void testPastBusinessDate() {
assertEquals(bCalendar.minusBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), 3),
assertEquals(bCalendar.minusBusinessDays(bCalendar.calendarDate(), 3),
bCalendar.pastBusinessDate(3));
assertEquals(bCalendar.minusBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), -3),
assertEquals(bCalendar.minusBusinessDays(bCalendar.calendarDate(), -3),
bCalendar.pastBusinessDate(-3));
assertNull(bCalendar.pastBusinessDate(NULL_INT));
}

public void testFutureNonBusinessDate() {
assertEquals(bCalendar.plusNonBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), 3),
assertEquals(bCalendar.plusNonBusinessDays(bCalendar.calendarDate(), 3),
bCalendar.futureNonBusinessDate(3));
assertEquals(bCalendar.plusNonBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), -3),
assertEquals(bCalendar.plusNonBusinessDays(bCalendar.calendarDate(), -3),
bCalendar.futureNonBusinessDate(-3));
assertNull(bCalendar.futureNonBusinessDate(NULL_INT));
}

public void testPastNonBusinessDate() {
assertEquals(bCalendar.minusNonBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), 3),
assertEquals(bCalendar.minusNonBusinessDays(bCalendar.calendarDate(), 3),
bCalendar.pastNonBusinessDate(3));
assertEquals(bCalendar.minusNonBusinessDays(DateTimeUtils.todayLocalDate(bCalendar.timeZone()), -3),
assertEquals(bCalendar.minusNonBusinessDays(bCalendar.calendarDate(), -3),
bCalendar.pastNonBusinessDate(-3));
assertNull(bCalendar.pastNonBusinessDate(NULL_INT));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,18 @@ public void testMinusDays() {
}

public void testCurrentDate() {
assertEquals(DateTimeUtils.todayLocalDate(calendar.timeZone()), calendar.calendarDate());
assertEquals(calendar.calendarDate(), calendar.calendarDate());
}

public void testFutureDate() {
assertEquals(calendar.plusDays(DateTimeUtils.todayLocalDate(calendar.timeZone()), 3), calendar.futureDate(3));
assertEquals(calendar.plusDays(DateTimeUtils.todayLocalDate(calendar.timeZone()), -3), calendar.futureDate(-3));
assertEquals(calendar.plusDays(calendar.calendarDate(), 3), calendar.futureDate(3));
assertEquals(calendar.plusDays(calendar.calendarDate(), -3), calendar.futureDate(-3));
assertNull(calendar.futureDate(NULL_INT));
}

public void testPastDate() {
assertEquals(calendar.minusDays(DateTimeUtils.todayLocalDate(calendar.timeZone()), 3), calendar.pastDate(3));
assertEquals(calendar.minusDays(DateTimeUtils.todayLocalDate(calendar.timeZone()), -3), calendar.pastDate(-3));
assertEquals(calendar.minusDays(calendar.calendarDate(), 3), calendar.pastDate(3));
assertEquals(calendar.minusDays(calendar.calendarDate(), -3), calendar.pastDate(-3));
assertNull(calendar.pastDate(NULL_INT));
}

Expand Down

0 comments on commit 8ba59b4

Please sign in to comment.