Minor touchups

deephaven · Mar 5, 2024 · ab73df0 · ab73df0
1 parent c174452
commit ab73df0
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java b/extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
@@ -533,7 +533,11 @@ public static void writeKeyValuePartitionedTable(@NotNull final Table sourceTabl
                 .map(ColumnDefinition::getName)
                 .toArray(String[]::new);
         final PartitionedTable partitionedTable = sourceTable.partitionBy(partitioningColNames);
-        writeKeyValuePartitionedTable(partitionedTable, definition, destinationDir, baseName, writeInstructions);
+        final TableDefinition keyTableDefinition = TableDefinition.of(partitioningColumns);
+        final TableDefinition leafDefinition =
+                getNonKeyTableDefinition(Arrays.asList(partitioningColNames), definition);
+        writeKeyValuePartitionedTableImpl(partitionedTable, keyTableDefinition, leafDefinition, destinationDir,
+                baseName, writeInstructions);
     }
 
     /**
@@ -610,6 +614,16 @@ public static void writeKeyValuePartitionedTable(@NotNull final PartitionedTable
                 baseName, writeInstructions);
     }
 
+    /**
+     * Write a partitioned table to disk in a key=value partitioning format with the already computed definition for the
+     * key table and leaf table.
+     * <p>
+     * Check {@link #writeKeyValuePartitionedTable(PartitionedTable, File, String, ParquetInstructions)},
+     * {@link #writeKeyValuePartitionedTable(PartitionedTable, TableDefinition, File, String, ParquetInstructions)},
+     * {@link #writeKeyValuePartitionedTable(PartitionedTable, File, String, ParquetInstructions)}}, or
+     * {@link #writeKeyValuePartitionedTable(PartitionedTable, TableDefinition, File, String, ParquetInstructions)} for
+     * more details.
+     */
     private static void writeKeyValuePartitionedTableImpl(@NotNull final PartitionedTable partitionedTable,
             @NotNull final TableDefinition keyTableDefinition,
             @NotNull final TableDefinition leafDefinition,