Ryan's feedback rnd2

deephaven · Nov 22, 2023 · cb09c5f · cb09c5f
1 parent 378d406
commit cb09c5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java b/engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
@@ -1183,8 +1183,8 @@ public static long callDataSnapshotFunction(
      * this method will perform a static snapshot without locks or retrying. In this case, the {@link SnapshotControl}'s
      * {@link SnapshotControl#usePreviousValues usePreviousValues} must return {@code false},
      * {@link SnapshotControl#snapshotCompletedConsistently snapshotCompletedConsistently} must return {@code true}, and
-     * the clock step returned by this method will be the {@link LogicalClock#NULL_CLOCK_VALUE NULL_CLOCK_VALUE}.
-     *
+     * the {@link LogicalClock#NULL_CLOCK_VALUE NULL_CLOCK_VALUE} will be supplied to {@code usePreviousValues} and
+     * {@code snapshotCompletedConsistently}.
      *
      * @param logPrefix A prefix for our log messages
      * @param control A {@link SnapshotControl} to define the parameters and consistency for this snapshot

diff --git a/server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java b/server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
@@ -2042,8 +2042,10 @@ private void finalizeSnapshotForSubscriptions(final List<Subscription> subscript
                     || isBlinkTable;
 
             if (log.isDebugEnabled()) {
-                log.debug().append(logPrefix).append("finalizing snapshot for subscription=")
-                        .append(subscription.logPrefix).append(", isComplete=").append(isComplete).endl();
+                log.debug().append(logPrefix)
+                        .append(subscription.logPrefix)
+                        .append("finalizing snapshot isComplete=").append(isComplete)
+                        .endl();
             }
 
             if (isComplete) {