Skip to content

Commit

Permalink
arrow stuff to include elsewhere
Browse files Browse the repository at this point in the history
  • Loading branch information
kosak committed Nov 19, 2023
1 parent 5fb7f8b commit f4eb98d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@
namespace deephaven::client::utility {
arrow::flight::FlightDescriptor ConvertTicketToFlightDescriptor(const std::string &ticket);

/**
* If status is OK, do nothing. Otherwise throw a runtime error with an informative message.
* @param debug_info A DebugInfo object, typically as provided by DEEPHAVEN_LOCATION_EXPR.
* @param status the arrow::Status
*/
void OkOrThrow(const deephaven::dhcore::utility::DebugInfo &debug_info, const arrow::Status &status);

/**
* If result's status is OK, do nothing. Otherwise throw a runtime error with an informative message.
* @param debug_info A DebugInfo object, typically as provided by DEEPHAVEN_LOCATION_EXPR.
Expand All @@ -25,13 +32,6 @@ void OkOrThrow(const deephaven::dhcore::utility::DebugInfo &debug_info, const ar
OkOrThrow(debug_info, result.status());
}

/**
* If status is OK, do nothing. Otherwise throw a runtime error with an informative message.
* @param debug_info A DebugInfo object, typically as provided by DEEPHAVEN_LOCATION_EXPR.
* @param status the arrow::Status
*/
void OkOrThrow(const deephaven::dhcore::utility::DebugInfo &debug_info, const arrow::Status &status);

/**
* If result's internal status is OK, return result's contained value.
* Otherwise throw a runtime error with an informative message.
Expand Down
2 changes: 0 additions & 2 deletions cpp-client/deephaven/dhclient/src/utility/arrow_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
#include <arrow/flight/types.h>
#include "deephaven/dhcore/utility/utility.h"

using namespace std;

namespace deephaven::client::utility {
void OkOrThrow(const deephaven::dhcore::utility::DebugInfo &debug_info,
const arrow::Status &status) {
Expand Down

0 comments on commit f4eb98d

Please sign in to comment.