-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Groovy classloader experience #4596
Changes from 11 commits
244332c
f358b19
13a52ef
b792d98
7829979
6350a44
6430a18
20173c0
1edebd9
d598e24
6fd97cc
97bebb4
8c0ed1e
f86dd36
c92bcf9
763a887
bc670ba
ac404fb
625080d
9a073f1
12267fa
7c9b700
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
import io.deephaven.engine.testutil.junit4.EngineCleanup; | ||
import io.deephaven.util.SafeCloseable; | ||
import org.jetbrains.annotations.NotNull; | ||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
|
@@ -31,7 +32,11 @@ public void setUp() { | |
.captureQueryScope() | ||
.captureUpdateGraph() | ||
.build().open(); | ||
} | ||
|
||
@After | ||
public void tearDown() { | ||
executionContext.close(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure how we got away with not closing the exec context before, are we possibly just opening other context on top of it and never checking that none were leaked? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing is helpful to ensure that we are setting it before every test that needs it. It is otherwise not an error to not "close" an open execution at this time. Thanks for finding that it was missing here! |
||
} | ||
|
||
// @Test | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package io.deephaven.engine.util.scripts | ||
|
||
println "Hello from script." | ||
println "Hello 1 from script." | ||
println "Hello 2 from script." | ||
println "Hello 3 from script." | ||
throw new RuntimeException("Busted") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
package io.deephaven.engine.util.scripts | ||
|
||
throw new RuntimeException("Busted Short") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this? thought it was deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added for test classpaths only, as an example used in DHE tests for groovy parameter disambiguation hit one of these methods.