Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventDrivenUpdateGraph. #4613

Merged
merged 33 commits into from
Dec 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5ae47e6
EventDrivenUpdateGraph.
cpwright Oct 10, 2023
9e51eb5
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 12, 2023
fd2f6ab
bad import
cpwright Oct 12, 2023
36cf076
Comment on PoisonedNotificationProcessor.
cpwright Oct 12, 2023
16ffa3b
running into state problems.
cpwright Oct 12, 2023
b77d836
rename stuff
cpwright Oct 16, 2023
5a5e078
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 17, 2023
bc7df8a
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 19, 2023
662280c
move graph name collision check into base.
cpwright Oct 19, 2023
7dcb72f
test, but in an impossible place
cpwright Oct 20, 2023
823ce85
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 23, 2023
5a42f31
Use EDUG for default.
cpwright Oct 24, 2023
7a9fa30
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 24, 2023
bfac9cc
flush reset
cpwright Oct 24, 2023
4fc1e2b
also clear on end
cpwright Oct 24, 2023
9b4b295
some comments
cpwright Oct 24, 2023
990b92f
spotless
cpwright Oct 24, 2023
434b338
self-review.
cpwright Oct 24, 2023
0bfac33
rset UPT.
cpwright Oct 24, 2023
0c4790c
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 26, 2023
3977fd8
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 26, 2023
19cfb88
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Oct 27, 2023
c66f342
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Nov 29, 2023
678af75
Merge remote-tracking branch 'upstream/main' into cpw_edug
cpwright Dec 5, 2023
c182b5d
live code review comments to address.
cpwright Dec 5, 2023
f7e6dca
cleanup
cpwright Dec 5, 2023
d326db9
spotless
cpwright Dec 5, 2023
793f744
javadoc
cpwright Dec 5, 2023
ee0fa06
Cleanup of unused variables, move budget calculation.
cpwright Dec 5, 2023
0e3add2
Fix existingOrBuild.
cpwright Dec 5, 2023
dcc53f8
speling.
cpwright Dec 5, 2023
7eaa896
Apply suggestions from code review
cpwright Dec 5, 2023
407bda9
spotless
cpwright Dec 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
cpwright and rcaudy authored Dec 5, 2023
commit 7eaa8968126022555c8849a6deeb7a243d724008
Original file line number Diff line number Diff line change
@@ -1034,11 +1034,10 @@ public static boolean removeInstance(final String name) {
}

/**
* Inserts the given UpdateGraph into the INSTANCES array. It is an error to do so if instance already exists with
* the name provided to this builder.
* Builds and caches a new UpdateGraph named {@code name} and provided by {@code construct}. It is an error if there is already an UpdateGraph with the same name.
*
* @param name the name of the new update graph
* @param construct a {@link Supplier} that constructs an UpdateGraph if no update graph with the name already
* @param construct A {@link Supplier} to construct an UpdateGraph if no update graph with the name already
* exists. The Supplier must provide an update graph with the given name.
*
* @throws IllegalStateException if an UpdateGraph with the provided name already exists
@@ -1057,10 +1056,10 @@ public static <T extends UpdateGraph> T buildOrThrow(final String name, final Su
}

/**
* Returns an existing UpdateGraph with the name provided to this Builder, if one exists, else returns a new
* UpdateGraph.
* Returns an existing UpdateGraph with the provided {@code name} if one exists, else returns a new
* named UpdateGraph supplied by {@code construct}.
*
* @param construct a {@link Supplier} that constructs an UpdateGraph if no update graph with the name already
* @param construct A {@link Supplier} to construct an UpdateGraph if no update graph with the name already
* exists. The Supplier must provide an update graph with the given name.
*
* @return the UpdateGraph