Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception for an unsupported case while reading parquet file #4640

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Added exception for an unsupported case while reading parquet file #4640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,7 @@ public Table aggAllBy(AggSpec spec, ColumnName... groupByColumns) {
* @param tableColumns the table columns
* @return the aggregation, if non-empty
*/
@VisibleForTesting
malhotrashivam marked this conversation as resolved.
Show resolved Hide resolved
static Optional<Aggregation> singleAggregation(
AggSpec spec, Collection<? extends ColumnName> groupByColumns,
Collection<? extends ColumnName> tableColumns) {
Expand Down
5 changes: 5 additions & 0 deletions extensions/parquet/base/src/main/java/io/deephaven/parquet/base/LevelsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ public void addElements(int elementsCount) {

@Override
public void addValues(int valuesCount) {
if (rangeCap.position() == 0) {
throw new IllegalStateException("Cannot add more values to this repeating level. It's possible that a "
+ "single row is getting split across pages, which is not supported.");
// TODO(deephaven-core:#4628) - Support this case
}
rangeCap.put(rangeCap.position() - 1, childValueCount += valuesCount);
}

Expand Down
Loading