Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove Kafka consumer properties #4646

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

rbasralian
Copy link
Contributor

Don't remove Kafka consumer properties (they should be reusable by multiple ingesters).

@rbasralian rbasralian marked this pull request as ready for review October 16, 2023 17:39
@rcaudy rcaudy requested a review from devinrsmith October 16, 2023 17:47
@rcaudy rcaudy assigned rcaudy and rbasralian and unassigned rcaudy Oct 16, 2023
@rcaudy rcaudy added feature request New feature or request core Core development tasks kafka ReleaseNotesNeeded Release notes are needed and removed NoReleaseNotesNeeded No release notes are needed. labels Oct 16, 2023
@rcaudy rcaudy added this to the September 2023 milestone Oct 16, 2023
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to also set properties on passed-in user confiigs; I've audited the code, and thankfully that logic was already removed.

@devinrsmith devinrsmith merged commit 4f43d53 into deephaven:main Oct 16, 2023
22 of 24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
@rbasralian rbasralian deleted the raffi_keep_consumer_props branch October 16, 2023 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core development tasks feature request New feature or request kafka NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants