Fix intermittent build failure, ensuring docker test output is still usable #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n when the run (test) fails. (deephaven#4254)" This reverts commit 51b88b3.
niloc132
added
build
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
approved these changes
Oct 23, 2023
jcferretti
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #4254, and rewrites the changes to now only support the use case that it was written for, but also avoid the gradle artifact issue that it appears to have introduced. The patch works by both using dependsOn and finalizedBy to set up two different downstream Sync tasks that do the same thing - but only one runs on success, and only one runs on failure. The success task uses dependsOn, and is now deemed suitable by Artifact.builtBy, and the failure one ensures that we see log files from failed builds/tests.
Fixes #4691