Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: Reuse Results When Possible #4752

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Select: Reuse Results When Possible #4752

merged 7 commits into from
Nov 6, 2023

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Oct 31, 2023 •
edited
Loading

Fixes #4751; enabling re-use of an already flattened parent column.

This also fixes:

  • an infinite recursion when flattening is reverted (it was recursively calling the wrong version of the method)
  • the loss of internally flattening if a SourceColumn refers to a new, already flattened, result column (cause this is safe)

Nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/6746760106/

@nbauernfeind nbauernfeind added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Oct 31, 2023
@nbauernfeind nbauernfeind added this to the October 2023 milestone Oct 31, 2023
@nbauernfeind nbauernfeind self-assigned this Oct 31, 2023
@nbauernfeind nbauernfeind requested a review from cpwright November 2, 2023 18:33
cpwright
cpwright previously approved these changes Nov 2, 2023
View reviewed changes
@nbauernfeind nbauernfeind requested a review from cpwright November 2, 2023 18:43
cpwright
cpwright previously approved these changes Nov 2, 2023
View reviewed changes
@nbauernfeind nbauernfeind requested a review from cpwright November 2, 2023 23:10
@nbauernfeind nbauernfeind enabled auto-merge (squash) November 3, 2023 19:18
@nbauernfeind nbauernfeind changed the title Static Select: Reuse Already Flattened Results Select: Reuse Results When Possible Nov 3, 2023
@nbauernfeind nbauernfeind disabled auto-merge November 3, 2023 20:42
@nbauernfeind nbauernfeind enabled auto-merge (squash) November 3, 2023 20:42
@nbauernfeind nbauernfeind mentioned this pull request Nov 6, 2023
Open
@nbauernfeind nbauernfeind merged commit ab5ea92 into deephaven:main Nov 6, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

@rcaudy rcaudy Awaiting requested review from rcaudy

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

SELECT_STATIC May Flatten a Source Column More Than Once
2 participants
@nbauernfeind @cpwright