-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryPerformanceRecorder: Group Batched Operations as a Single Query #4760
Conversation
085e09b
to
e4506cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python LGTM. Did not review the rest. Let me know if I need to.
4d702c3
to
30266ed
Compare
30266ed
to
771ec36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on two commits
...ne/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorderImpl.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateBy.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorder.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorder.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorderImpl.java
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorderImpl.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceRecorderImpl.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/perf/QueryPerformanceNugget.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/partitionedtable/PartitionedTableServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/table/ops/TableServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/table/ops/TableServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/table/ops/TableServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Fixes #4696.
Fixes #4765.
Change Highlights:
EvaluationNumber
on the QueryPerformanceLog enabling a batch query to kick off multiple sub queries.OperationNumber
on the QueryOperationPerfomanceLog enabling easier interaction for users.EvaluationNumber
usages (and blink-table columns) toLong
.PerformanceEntry#id
to along
(and propagates to blink-table columns).QueryPerformanceNugget
directly.Nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/6900780591/
Here is a script that can be used to create the hierarchical table view -- perhaps it should be available to all via an
EngineMetrics
accessor method.Groovy:
Python:
And for fun here's a lovely screen shot using the java-client TableManagerExample which sends several batches: