Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Parquet TIME #4775

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Added support for Parquet TIME #4775

merged 4 commits into from
Nov 7, 2023

Conversation

malhotrashivam
Copy link
Contributor

@malhotrashivam malhotrashivam commented Nov 6, 2023 •
edited
Loading

Closes #4753

Interesting reference: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#temporal-types

Release notes (combined with #4755):

  • Added support to write java.time.LocalDate as Parquet DATE and java.time.LocalTime as Parquet TIME format.
  • Earlier, Parquet DATE and TIME columns were read as integers. After these changes, they will be read as java.time.LocalDate and java.time.LocalTime respectively.

@malhotrashivam malhotrashivam added feature request New feature or request core Core development tasks parquet Related to the Parquet integration NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Nov 6, 2023
@malhotrashivam malhotrashivam added this to the October 2023 milestone Nov 6, 2023
@malhotrashivam malhotrashivam self-assigned this Nov 6, 2023
@malhotrashivam malhotrashivam added ReleaseNotesNeeded Release notes are needed and removed NoReleaseNotesNeeded No release notes are needed. labels Nov 6, 2023
rcaudy
rcaudy reviewed Nov 6, 2023
View reviewed changes
engine/time/src/main/java/io/deephaven/time/DateTimeUtils.java Outdated Show resolved Hide resolved
engine/time/src/main/java/io/deephaven/time/DateTimeUtils.java Outdated Show resolved Hide resolved
...ions/parquet/table/src/main/java/io/deephaven/parquet/table/pagestore/topage/ToTimePage.java Outdated Show resolved Hide resolved
py/server/tests/test_parquet.py Show resolved Hide resolved
replication/util/src/main/java/io/deephaven/replication/ReplicatePrimitiveCode.java Outdated Show resolved Hide resolved
replication/util/src/main/java/io/deephaven/replication/ReplicatePrimitiveCode.java Show resolved Hide resolved
...et/table/src/main/java/io/deephaven/parquet/table/transfer/PrimitiveTransferArrayBacked.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@malhotrashivam malhotrashivam merged commit 24f8182 into deephaven:main Nov 7, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@jmao-denver jmao-denver Awaiting requested review from jmao-denver jmao-denver is a code owner

Assignees

@malhotrashivam malhotrashivam

Labels
core Core development tasks feature request New feature or request NoDocumentationNeeded parquet Related to the Parquet integration ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Support for Parquet DATE and TIME types
2 participants
@malhotrashivam @rcaudy