Python Client import_table
Should not also Close the Writer
#4777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes last night's nightly-ci failure. Note that the failure is difficult to reproduce as there is some racing involved. However, do note that
DoPut
requires the stream to be cancelled before it is considered complete. Since there are python tests that round-trip to ensure the data uploaded is readable we can be confident that theDoPut
is being closed by the pyarrow library. (I did attempt to follow the code path through the cpp implementation, but it was hard for me to find the specificWriteTable
call that is being invoked in this context.)