Update protoc and cpp client base images. #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this pull request
Nov 9, 2023
Update some unit testing gradle wrapper versions to ensure gradle works with OpenJDK 21 deephaven/deephaven-server-docker#69 deephaven/deephaven-server-docker#70 Not updating cpp or protoc base, see deephaven/deephaven-base-images#102 deephaven#4805
|
FYI @niloc132; deephaven/deephaven-base-images#102 look OK to you? |
niloc132
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
I looked at this and the linked PR in base-images - I don't think I have anything constructive to add or to call out. The changes might not appear ideal, but they come from a place of "this is the clearest/quickest way to keep our build wiring consistent", and its hard to argue with that.
devinrsmith
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with the protoc image generation that was introduced in the R related refactor for deephaven-base-images.
We are also updating the cpp image to include the change in build-dependencies.sh (and link to it from the cpp-client/README) that allows for customizing the github URL (per Raffi's request).