TableServiceAsyncTest: Eliminate Compiler Overhead Variance; Close QueryCompiler's JavaFileManager
#4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
devinrsmith
reviewed
Nov 10, 2023
Comment on lines
98
to
100
| // to avoid timeouts due to compilation variance reuse the same expression, including the destination | ||
| // column which shows up in the generated formula's FormulaEvaluationException | ||
| longChain.add(prev.updateView("I_1 = 1 + I_0")); |
There was a problem hiding this comment.
I'm not sure how this is directly related to #4798; that is specifically around a timeout error. I'd assume in the case of too many open files in the compilation path there will be some other error that causes TableServiceAsyncTest to fail, correct?
There was a problem hiding this comment.
Everytime it was timed out the server was in the middle of compiling. I did a bunch of instrumentation - there is no real issue with the test, just that the variance of compilation causes it to time out. Repeated local runs are actually harder to time out because the classes have been precompiled.
The change that you are commenting on here, is the actual fix -- run the long chain without repeatedly invoking the compiler. If you prefer, we can split this out from the singleton creation.
There was a problem hiding this comment.
Ah, makes sense; I never saw that high of variation likely due to the points you bring up.
java-client/session-dagger/src/test/java/io/deephaven/client/impl/TableServiceAsyncTest.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Nov 10, 2023
java-client/session/src/main/java/io/deephaven/client/impl/Session.java
Outdated
Show resolved
Hide resolved
java-client/session-dagger/src/test/java/io/deephaven/client/impl/TableServiceAsyncTest.java
Outdated
Show resolved
Hide resolved
rcaudy
requested changes
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
java-client/session/src/main/java/io/deephaven/client/impl/Session.java
Outdated
Show resolved
Hide resolved
java-client/session-dagger/src/test/java/io/deephaven/client/impl/TableServiceAsyncTest.java
Show resolved
Hide resolved
nbauernfeind
changed the title
TableServiceAsyncTest: Eliminate Compiler Overhead Variance; Close QueryCompiler's JavaFileManager
nbauernfeind
force-pushed
the
gh_4798
branch
from
cdc5232 to
68d7ef6
Compare
nbauernfeind
force-pushed
the
gh_4798
branch
from
68d7ef6 to
1fcb864
Compare
rcaudy
reviewed
Nov 10, 2023
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
engine/context/src/main/java/io/deephaven/engine/context/QueryCompiler.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Nov 10, 2023
rcaudy
approved these changes
Nov 10, 2023
devinrsmith
approved these changes
Nov 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4798.
Follow up work #4814.
Whenever I could catch a timeout in the debugger the server was not blocked, always making progress, but spending time in compilation. I've eliminated the need to recompile formulas for each operation in the chain and added some validation that the data in the result tables are as expected.
While testing ways to reproduce and/or fix the original issue, I discovered that the
JavaFileManagerthat we're creating on every compilation request opened file handles for many of the jars on my classpath. After around 50'ish queries theQueryCompilerbroke complaining ofToo many open files. Running a quicklsof | cut | sort | uniq -cshowed 40+ open file handles each on many of the jars on my classpath. I've done the bare minimum in this PR, will write a follow up issue, and discuss via team-slack.Multiplexed this PR's Check CI here: https://github.com/nbauernfeind/deephaven-core/actions/runs/6830355652
Multiplexed current main's Check CI here: https://github.com/nbauernfeind/deephaven-core/actions/runs/6830357421/
(I expect to see a failure or three in the current main and none for this PR as it's hard to tell if the issue has been fixed.)