-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryPerformanceRecorder: Changes for CorePlus Integration #4862
Conversation
The performance queries should reintroduce Durations and an IntervalDuration as derived columns. |
7606682
to
870f277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. I do want to raise that we're now calculating UPL interval duration by delta of wall-clock time, rather than delta of "monotonic" time. Are we sure we like this change?
Just to close the loop on the discussion, in case we ever look at this PR again: We discussed offline that we're happy with duration being computed using wall-clock time given that usage nanos is the sum of [parallelized] System.nanoTime. |
No description provided.