ConstructSnapshot + BarrageMessageProducer: Use Static ConstructSnapshot Fast Path #4876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following query:
The result table is a static table built without an
ExecutionContext
, as should be allowed.However, the captured update graph is the
PoisonedUpdateGraph
which throws inConstructSnapshot
. WhileConstructSnapshot
allows for anull
UpdateGraph
, theSnapshotControl
does not "go through the motions" of an otherwise typical snapshot.Conveniently, this fix will snapshot static tables (even those that capture a valid UpdateGraph) to work their way through
ConstructSnapshot
with less hassle, no locks, and no unnecessary retries.