Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect JsPlugin instances before starting Jetty #4885

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

niloc132
Copy link
Member

This reverses a DI dependency, preventing requiring that the server start up before plugins can be collected.

Partial #4040

This reverses a DI dependency, preventing requiring that the server
start up before plugins can be collected.

Partial deephaven#4040
@niloc132 niloc132 added this to the November 2023 milestone Nov 27, 2023
@niloc132 niloc132 requested a review from devinrsmith November 27, 2023 21:13
@niloc132 niloc132 requested a review from devinrsmith November 27, 2023 23:01
@niloc132 niloc132 merged commit e09bcfd into deephaven:main Nov 28, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants