Fix github action release versioning #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the -SNAPSHOT qualifier for all github action release branch gradle invocations. This also makes a point to update the RELEASE.md in the one place where the release manager invokes gradlew. Follow-up fix for deephaven#4865
devinrsmith
requested review from
jcferretti,
stanbrub,
JamesXNelson,
mofojed and
rcaudy
as code owners
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
mofojed
approved these changes
Nov 28, 2023
stanbrub
approved these changes
Nov 28, 2023
| if [[ "${GITHUB_REF}" == refs/heads/release/v* ]]; | ||
| then | ||
| echo "deephavenBaseQualifier=" | ||
| fi |
There was a problem hiding this comment.
Does this also fix gradlew "outputVersion"?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the -SNAPSHOT qualifier for all github action release branch gradle invocations. This also makes a point to update the RELEASE.md in the one place where the release manager invokes gradlew.
Follow-up fix for #4865