Auto convert md np array to java array for the output of Python UDFs #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
DocumentationNeeded
python-server-side
ReleaseNotesNeeded
jmao-denver
changed the title
jmao-denver
changed the title
chipkent
reviewed
Jan 9, 2024
| @@ -210,7 +212,7 @@ def f() -> np.ndarray[np.int64]: | |||
|
|
|||
| with self.assertRaises(DHError) as cm: | |||
| t = empty_table(10).update(["X1 = f()"]) | |||
| self.assertIn("not support multi-dimensional arrays", str(cm.exception)) | |||
| self.assertIn("java.lang.ClassCastException: class [[J cannot be cast to class [J", str(cm.exception)) | |||
There was a problem hiding this comment.
Can we get a more python-user-friendly error message, or is the whole message python friendly, and this is just a snippet?
There was a problem hiding this comment.
It is the most important part of the message (including the full trackback etc.) and it is emitted out of the engine. I don't know there is a safe and easy way to make it more Python-user-friendly.
jmao-denver
changed the title
jmao-denver
force-pushed
the
4989-ndarray-out
branch
from
e363c3c to
42d3b2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4989