-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move calendar initialization to server startup #5037
Merged
devinrsmith
merged 6 commits into
deephaven:main
from
devinrsmith:calendars-dagger-configuration
Jan 16, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4ab02c7
Move calendar initialization to server startup
devinrsmith 3e78f4e
Merge remote-tracking branch 'upstream/main' into calendars-dagger-co…
devinrsmith bc49c3e
Review comment
devinrsmith 1f4480e
Move to a better / guarded implementation for CalendarInit
devinrsmith 4ac96ef
Move more usage to guarded model. Document python test entrypoint
devinrsmith 56c5b05
Consolidate calendar init test logic
devinrsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
Integrations/src/test/java/io/deephaven/integrations/python/CalendarsHelper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/** | ||
* Copyright (c) 2016-2023 Deephaven Data Labs and Patent Pending | ||
*/ | ||
package io.deephaven.integrations.python; | ||
|
||
import io.deephaven.time.calendar.BusinessCalendar; | ||
import io.deephaven.time.calendar.Calendars; | ||
|
||
public final class CalendarsHelper { | ||
devinrsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public static void addCalendarsFromConfiguration() { | ||
devinrsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
for (BusinessCalendar calendar : Calendars.calendarsFromConfiguration()) { | ||
Calendars.addCalendar(calendar); | ||
} | ||
devinrsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
Plot/src/test/java/io/deephaven/plot/axistransformations/CalendarInit.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** | ||
* Copyright (c) 2016-2023 Deephaven Data Labs and Patent Pending | ||
*/ | ||
package io.deephaven.plot.axistransformations; | ||
|
||
import io.deephaven.time.calendar.BusinessCalendar; | ||
import io.deephaven.time.calendar.Calendars; | ||
|
||
final class CalendarInit { | ||
static { | ||
for (BusinessCalendar calendar : Calendars.calendarsFromConfiguration()) { | ||
Calendars.addCalendar(calendar); | ||
} | ||
} | ||
|
||
static void noop() { | ||
|
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test configuration for calendars feels like it is spread all over the place.
CalendarsHelper
and two differentCalendarInit
do roughly the same thing in different ways, including the opaque, undocumentednoop()
method. Is there any reason that all of this logic shouldn't be consolidated into a singleCalendars.addCalendarsFromConfiguration()
method?