Use a Deque to avoid StackOverflow in ImmediateJobScheduler #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
core
nbauernfeind
force-pushed
the
immediate_job_sched
branch
2 times, most recently
from
6695cfd to
389006e
Compare
rcaudy
reviewed
Jan 26, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/util/ImmediateJobScheduler.java
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
immediate_job_sched
branch
from
389006e to
efa4d95
Compare
rcaudy
reviewed
Jan 26, 2024
| @@ -49,7 +51,7 @@ public void submit( | |||
| job.run(); | |||
| } | |||
| } finally { | |||
| processingThread.set(null); | |||
| PROCESSING_THREAD_UPDATER.set(this, null); | |||
There was a problem hiding this comment.
This is OK, but you can also just do the assignment:
processingThread = null;
rcaudy
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoid StackOverflowErrors during select/update operations with many layers.