Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the comparison of String and LocalDate #5079

Closed
wants to merge 2 commits into from

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Jan 26, 2024

For backwards compatibility reasons, it is desirable to be able to directly compare String and LocalDate objects. There is potential overhead from doing this, but the overhead was determined to be acceptable for not breaking compatibility.

For example:

from deephaven import empty_table

t = empty_table(1).update([
    "X = '2021-01-13'",
    "Y = new String[]{`2021-01-12`,`2021-01-13`,`2021-01-14`}"
]).ungroup()

t2 = t.where("X > Y")
image

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the kind of change I had in mind. It needs to go through io.deephaven.engine.table.impl.lang.QueryLanguageFunctionGenerator however.

@chipkent
Copy link
Member Author

I believe the final decision was to not make conversions.

@chipkent chipkent closed this Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants