Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SafeCloseable context manager wrapper #5251

Merged
merged 9 commits into from
Mar 16, 2024
Merged

Add SafeCloseable context manager wrapper #5251

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c12ecf3
Add SafeCloseable wrapper
arman-ddl Mar 14, 2024
fbc4609
Add SafeCloseable test
arman-ddl Mar 15, 2024
66fcfc8
Extend JObjectWrapper
arman-ddl Mar 15, 2024
2d54701
Polish
arman-ddl Mar 15, 2024
8bb8664
Polish
arman-ddl Mar 15, 2024
ae90b46
Apply suggestions from code review
arman-ddl Mar 15, 2024
95e599a
Document assumption
arman-ddl Mar 15, 2024
2b70878
Polish pydoc
arman-ddl Mar 15, 2024
67421f4
Change SafeCloseable to AutoCloseable
arman-ddl Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion py/server/deephaven/jcompat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ def _j_array_to_series(dtype: DType, j_array: jpy.JType, conv_null: bool) -> pd.


class SafeCloseable(JObjectWrapper):
arman-ddl marked this conversation as resolved.
Show resolved Hide resolved
"""A context manager wrapper of Java SafeCloseable to emulate Java try-with-resources."""
"""A context manager wrapper to allow Java SafeCloseable to be used in with statements. Assumes Java
SafeCloseable has not been closed yet."""
arman-ddl marked this conversation as resolved.
Show resolved Hide resolved

j_object_type = jpy.get_type("io.deephaven.util.SafeCloseable")

Expand Down
2 changes: 1 addition & 1 deletion py/server/tests/test_jcompat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def int_to_str(v: int) -> str:
def test_safe_closeable(self):
safe_closeable = SafeCloseable(_JSharedContext.makeSharedContext())
chipkent marked this conversation as resolved.
Show resolved Hide resolved
with safe_closeable:
pass
self.assertEqual(safe_closeable.closed, False)
self.assertEqual(safe_closeable.closed, True)


Expand Down
Loading