-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Docs ci condition on latest link #5615
base: main
Are you sure you want to change the base?
build: Docs ci condition on latest link #5615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should discuss more generally with release manager / release channel how we want to handle this so we can be consistent across our jobs. I'm haven't looked into the git tag --sort
command yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not merge this until we have agreed upon a proper path more generally for the release process. See #5631
Removed using config/temp-tag and now use standard sort version instead. Tests show that this behaves like git's sort version mechanism. So, no git config, no temporary tag, and uses a standard utility that's available in the OS install. We could turn this into a script if that's better for sharing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Related: #5591