Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Docs ci condition on latest link #5615

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

stanbrub
Copy link
Contributor

@stanbrub stanbrub commented Jun 13, 2024

  • Added checkout to symlink and some git setup
  • Add git sort of versions to tell latest
  • Set latest link always to the latest version, not the current branch version
  • Tested this on my fork and local branch on deephaven-core

Related: #5591

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss more generally with release manager / release channel how we want to handle this so we can be consistent across our jobs. I'm haven't looked into the git tag --sort command yet.

.github/workflows/docs-ci.yml Outdated Show resolved Hide resolved
@rcaudy rcaudy added this to the June 2024 milestone Jun 14, 2024
@stanbrub stanbrub requested a review from devinrsmith June 17, 2024 20:03
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not merge this until we have agreed upon a proper path more generally for the release process. See #5631

.github/workflows/docs-ci.yml Outdated Show resolved Hide resolved
@stanbrub
Copy link
Contributor Author

Removed using config/temp-tag and now use standard sort version instead. Tests show that this behaves like git's sort version mechanism. So, no git config, no temporary tag, and uses a standard utility that's available in the OS install.

We could turn this into a script if that's better for sharing.

@stanbrub stanbrub requested a review from devinrsmith June 24, 2024 18:52
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pete-petey pete-petey removed this from the June 2024 milestone Aug 26, 2024
@pete-petey pete-petey added this to the Backlog milestone Aug 26, 2024
@stanbrub stanbrub changed the title Docs ci condition on latest link build: Docs ci condition on latest link Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants