Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct instantiation of rollup count_where operator. #6502

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

lbooker42
Copy link
Contributor

#6497 merged with an error where the rollup count_where aggregation was aliased to the regular count_ aggregation.

This PR corrects that mistake.

@lbooker42 lbooker42 added bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Dec 20, 2024
@lbooker42 lbooker42 added this to the 0.38.0 milestone Dec 20, 2024
@lbooker42 lbooker42 self-assigned this Dec 20, 2024
jmao-denver
jmao-denver previously approved these changes Dec 30, 2024
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM

@lbooker42 lbooker42 merged commit 492121d into deephaven:main Dec 30, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
@lbooker42 lbooker42 deleted the lab-countwhere-rollup branch December 30, 2024 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants