Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct two errors in generated types #6536

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Jan 8, 2025

Output is now validated in the build - CI will fail if there is an error in the future.

Fixes DH-18194
Backport #6498

Output is now validated in the build - CI will fail if there is an error
in the future.

Fixes DH-18194
@niloc132 niloc132 added documentation Improvements or additions to documentation jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Jan 8, 2025
@niloc132 niloc132 added this to the 0.37.1 milestone Jan 8, 2025
@niloc132 niloc132 requested review from bmingles and mofojed January 8, 2025 19:15
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcaudy rcaudy modified the milestones: 0.37.1, 0.37.2 Jan 8, 2025
@devinrsmith devinrsmith changed the title fix: Correct two errors in generated types (#6498) fix: Correct two errors in generated types Jan 8, 2025
@devinrsmith devinrsmith merged commit 0ee333c into deephaven:rc/v0.37.x Jan 8, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants