fix: Increase timeout to almost guarantee 2 PUG cycles to eliminate random test failures #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
python-server-side
NoReleaseNotesNeeded
jmao-denver
requested review from
chipkent,
rcaudy and
cpwright
as code owners
cpwright
reviewed
Jan 13, 2025
| # failure_cb will be called in the background thread after 2 PUG cycles | ||
| self.wait_ticking_table_update(table, 600, 2) | ||
| # failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough | ||
| self.wait_ticking_table_update(table, 600, 3) |
There was a problem hiding this comment.
If the machine is loaded should we really say only 3 seconds? What do we have to lose by making the value higher? Will a higher value actually make a successful test take longer?
There was a problem hiding this comment.
A higher number does make the test take longer b/c the awaitUpdate method called underneath won't error out due to the table being in a failed state, so we'll exhaust the timeout.
cpwright
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random failures on the 2 test cases have been seen in CI/nightly recently.