Skip to content

Commit

Permalink
fix: set necessity_indicator default to None (#947)
Browse files Browse the repository at this point in the history
- Fixes #924 
- Set default of `necessity_indicator` to `None` so the prop can inherit
from parents if necessary
  • Loading branch information
wusteven815 authored Oct 22, 2024
1 parent d7bcc22 commit 3b25024
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/combo_box.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def combo_box(
validation_state: ValidationState | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator | None = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Element | None = None,
on_open_change: Callable[[bool, MenuTriggerAction], None] | None = None,
on_selection_change: Callable[[Key], None] | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/form.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def form(
auto_capitalize: AutoCapitalizeModes | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
on_submit: Callable[[dict[str, str]], None] | None = None,
on_reset: Callable[[dict[str, str]], None] | None = None,
on_invalid: Callable[[dict[str, str]], None] | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/number_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def number_field(
name: str | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Any | None = None,
on_focus: FocusEventCallable | None = None,
on_blur: FocusEventCallable | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/picker.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def picker(
is_loading: bool | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Element | None = None,
on_open_change: Callable[[bool], None] | None = None,
on_focus: FocusEventCallable | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/radio_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def radio_group(
error_message: Any | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Any | None = None,
show_error_icon: bool | None = None,
on_focus: FocusEventCallable | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/text_area.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def text_area(
validation_state: TextFieldValidationState | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Any | None = None,
on_focus: FocusEventCallable | None = None,
on_blur: FocusEventCallable | None = None,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/text_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def text_field(
validation_state: TextFieldValidationState | None = None,
label_position: LabelPosition = "top",
label_align: Alignment | None = None,
necessity_indicator: NecessityIndicator = "icon",
necessity_indicator: NecessityIndicator | None = None,
contextual_help: Any | None = None,
on_focus: FocusEventCallable | None = None,
on_blur: FocusEventCallable | None = None,
Expand Down

0 comments on commit 3b25024

Please sign in to comment.