Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into 294_picker_python
Browse files Browse the repository at this point in the history
  • Loading branch information
jnumainville committed Feb 23, 2024
2 parents c9d8ae7 + d5d003d commit 3bb7add
Show file tree
Hide file tree
Showing 47 changed files with 950 additions and 769 deletions.
17 changes: 17 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,20 @@ repos:
rev: 22.10.0
hooks:
- id: black
- repo: https://github.com/RobertCraigie/pyright-python
rev: v1.1.334
hooks:
- id: pyright
files: plugins.*\/src.*\.py
additional_dependencies:
[
pandas,
deephaven-core,
plotly,
json-rpc,
matplotlib
]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.2.2
hooks:
- id: ruff
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Start by setting up the python venv and pre-commit hooks.

### Pre-commit hooks/Python formatting

Black and blacken-docs formatting is setup through a pre-commit hook.
Black and blacken-docs formatting, pyright type checking, and ruff linting is setup through a pre-commit hook.
To install the pre-commit hooks, run the following commands from the root directory of this repo:

```shell
Expand All @@ -56,6 +56,11 @@ pre-commit run --all-files

All steps should pass.

To bypass the pre-commit hook, you can commit with the `--no-verify` flag, for example:
```shell
git commit --no-verify -m "commit message"`
```

### Running Python tests

The above steps will also set up `tox` to run tests for the python plugins that support it.
Expand Down
Loading

0 comments on commit 3bb7add

Please sign in to comment.