Skip to content

Commit

Permalink
ci: Always run the modified-plugin actions, don't use paths filter (#…
Browse files Browse the repository at this point in the history
…131)

- Checks skipped with the "paths" filter never run, but we want to have
branch protection based on the `test-python` and `test-js` steps
- GitHub recommends not filtering on paths for required actions:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
- Don't filter on paths for triggering the action; each step is already
conditional on if there were actually changes to the package or not
  • Loading branch information
mofojed authored Nov 22, 2023
1 parent 878aa91 commit 87da019
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/modified-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ name: Test Modified Plugin
on:
pull_request:
branches: [main]
paths:
- 'plugins/plotly-express/**'
- 'plugins/plotly/**'
- 'plugins/matplotlib/**'
- 'plugins/json/**'
- 'plugins/ui/**'
push:
branches: [main]
tags:
Expand Down

0 comments on commit 87da019

Please sign in to comment.