Skip to content

Commit

Permalink
Merge branch 'main' into documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanalvizo committed Apr 28, 2024
2 parents 494a959 + b0574c2 commit 92e0b5e
Show file tree
Hide file tree
Showing 94 changed files with 2,018 additions and 608 deletions.
876 changes: 478 additions & 398 deletions package-lock.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"update-dh-packages": "lerna run --concurrency 1 update-dh-packages"
},
"devDependencies": {
"@deephaven/babel-preset": "^0.40.0",
"@deephaven/eslint-config": "^0.40.0",
"@deephaven/prettier-config": "^0.40.0",
"@deephaven/tsconfig": "^0.40.0",
"@deephaven/babel-preset": "^0.72.0",
"@deephaven/eslint-config": "^0.72.0",
"@deephaven/prettier-config": "^0.72.0",
"@deephaven/tsconfig": "^0.72.0",
"@playwright/test": "^1.41.2",
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "^12.1.3",
Expand All @@ -47,7 +47,7 @@
"lerna": "^6.6.1",
"npm-run-all": "^4.1.5",
"nx": "15.9.2",
"prettier": "^2.8.7",
"prettier": "3.0.0",
"vite": "~4.1.4"
},
"prettier": "@deephaven/prettier-config"
Expand Down
10 changes: 5 additions & 5 deletions plugins/plotly-express/src/js/src/PlotlyExpressChartModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class PlotlyExpressChartModel extends ChartModel {
return this.layout;
}

override close() {
override close(): void {
super.close();
this.widget?.close();
this.widget = undefined;
Expand Down Expand Up @@ -180,7 +180,7 @@ export class PlotlyExpressChartModel extends ChartModel {
this.widget = undefined;
}

updateLayout(data: PlotlyChartWidgetData) {
updateLayout(data: PlotlyChartWidgetData): void {
const { figure } = data;
const { plotly } = figure;
const { layout: plotlyLayout = {} } = plotly;
Expand Down Expand Up @@ -255,7 +255,7 @@ export class PlotlyExpressChartModel extends ChartModel {
this.fireUpdate(this.getData());
}

addTable(id: number, table: Table) {
addTable(id: number, table: Table): void {
if (this.tableReferenceMap.has(id)) {
return;
}
Expand All @@ -267,7 +267,7 @@ export class PlotlyExpressChartModel extends ChartModel {
}
}

subscribeTable(id: number) {
subscribeTable(id: number): void {
const table = this.tableReferenceMap.get(id);
const columnReplacements = this.tableColumnReplacementMap.get(id);

Expand All @@ -292,7 +292,7 @@ export class PlotlyExpressChartModel extends ChartModel {
}
}

removeTable(id: number) {
removeTable(id: number): void {
this.subscriptionCleanupMap.get(id)?.();
this.tableSubscriptionMap.get(id)?.close();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import { useApi } from '@deephaven/jsapi-bootstrap';
import PlotlyExpressChartModel from './PlotlyExpressChartModel.js';
import { useHandleSceneTicks } from './useHandleSceneTicks.js';

export function PlotlyExpressChartPanel(props: WidgetPanelProps<Widget>) {
export function PlotlyExpressChartPanel(
props: WidgetPanelProps<Widget>
): JSX.Element {
const dh = useApi();
const { fetch, metadata = {}, ...rest } = props;
const containerRef = useRef<HTMLDivElement>(null);
Expand Down
8 changes: 4 additions & 4 deletions plugins/plotly-express/src/js/src/PlotlyExpressChartUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import type { Data, PlotlyDataLayoutConfig } from 'plotly.js';
import type { Table, Widget } from '@deephaven/jsapi-types';

export interface PlotlyChartWidget {
getDataAsBase64(): string;
exportedObjects: { fetch(): Promise<Table> }[];
addEventListener(
getDataAsBase64: () => string;
exportedObjects: { fetch: () => Promise<Table> }[];
addEventListener: (
type: string,
fn: (event: CustomEvent<PlotlyChartWidget>) => () => void
): void;
) => void;
}

export interface PlotlyChartWidgetData {
Expand Down
2 changes: 1 addition & 1 deletion plugins/plotly-express/src/js/src/useHandleSceneTicks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PlotlyExpressChartModel from './PlotlyExpressChartModel.js';
export function useHandleSceneTicks(
model: PlotlyExpressChartModel | undefined,
container: HTMLDivElement | null
) {
): void {
useEffect(() => {
// Plotly scenes and geo views reset when our data ticks
// Pause rendering data updates when the user is manipulating a scene
Expand Down
29 changes: 29 additions & 0 deletions plugins/ui/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,35 @@
All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.

- - -
## ui-v0.13.1 - 2024-04-22
#### Bug Fixes
- toggle_button was not passing through `on_change` (#427) - (d452a00) - mofojed

- - -

## ui-v0.13.0 - 2024-04-18
#### Bug Fixes
- Fix conditional use_effect in use_table_listener (#422) - (5f4f238) - Joe
- add on_change to toggle_button (#426) - (6ead733) - Joe
- buttons not working due to extra prop (#423) - (b10f67c) - Don
#### Features
- python date picker implementation (#409) - (5ed66a7) - Joe

- - -

## ui-v0.12.0 - 2024-04-17
#### Documentation
- Combo box spec (#392) - (da1076a) - Joe
- toggle button (#402) - (702ad2a) - ethanalvizo
- date picker spec (#388) - (e1a135d) - Joe
#### Features
- improve default dh.ui layouts (#411) - (67f82e3) - Don
- Picker - format settings (#394) - (f9a0e34) - bmingles
#### Tests
- bump ts, eslint and prettier configs (#416) - (a4761cc) - Don

- - -

## ui-v0.11.0 - 2024-04-03
#### Bug Fixes
- Re-opening widgets after re-hydrated (#379) - (42242a5) - mofojed
Expand Down
Loading

0 comments on commit 92e0b5e

Please sign in to comment.