Skip to content

Commit

Permalink
test: bump ts, eslint and prettier configs (#416)
Browse files Browse the repository at this point in the history
- Bumps configs to latest versions
- Update failing types and formatting caught by newer versions
  • Loading branch information
dsmmcken authored Apr 17, 2024
1 parent da1076a commit a4761cc
Show file tree
Hide file tree
Showing 33 changed files with 172 additions and 98 deletions.
158 changes: 108 additions & 50 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"update-dh-packages": "lerna run --concurrency 1 update-dh-packages"
},
"devDependencies": {
"@deephaven/babel-preset": "^0.40.0",
"@deephaven/eslint-config": "^0.40.0",
"@deephaven/prettier-config": "^0.40.0",
"@deephaven/tsconfig": "^0.40.0",
"@deephaven/babel-preset": "^0.72.0",
"@deephaven/eslint-config": "^0.72.0",
"@deephaven/prettier-config": "^0.72.0",
"@deephaven/tsconfig": "^0.72.0",
"@playwright/test": "^1.41.2",
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "^12.1.3",
Expand All @@ -47,7 +47,7 @@
"lerna": "^6.6.1",
"npm-run-all": "^4.1.5",
"nx": "15.9.2",
"prettier": "^2.8.7",
"prettier": "3.0.0",
"vite": "~4.1.4"
},
"prettier": "@deephaven/prettier-config"
Expand Down
10 changes: 5 additions & 5 deletions plugins/plotly-express/src/js/src/PlotlyExpressChartModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class PlotlyExpressChartModel extends ChartModel {
return this.layout;
}

override close() {
override close(): void {
super.close();
this.widget?.close();
this.widget = undefined;
Expand Down Expand Up @@ -180,7 +180,7 @@ export class PlotlyExpressChartModel extends ChartModel {
this.widget = undefined;
}

updateLayout(data: PlotlyChartWidgetData) {
updateLayout(data: PlotlyChartWidgetData): void {
const { figure } = data;
const { plotly } = figure;
const { layout: plotlyLayout = {} } = plotly;
Expand Down Expand Up @@ -255,7 +255,7 @@ export class PlotlyExpressChartModel extends ChartModel {
this.fireUpdate(this.getData());
}

addTable(id: number, table: Table) {
addTable(id: number, table: Table): void {
if (this.tableReferenceMap.has(id)) {
return;
}
Expand All @@ -267,7 +267,7 @@ export class PlotlyExpressChartModel extends ChartModel {
}
}

subscribeTable(id: number) {
subscribeTable(id: number): void {
const table = this.tableReferenceMap.get(id);
const columnReplacements = this.tableColumnReplacementMap.get(id);

Expand All @@ -292,7 +292,7 @@ export class PlotlyExpressChartModel extends ChartModel {
}
}

removeTable(id: number) {
removeTable(id: number): void {
this.subscriptionCleanupMap.get(id)?.();
this.tableSubscriptionMap.get(id)?.close();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import { useApi } from '@deephaven/jsapi-bootstrap';
import PlotlyExpressChartModel from './PlotlyExpressChartModel.js';
import { useHandleSceneTicks } from './useHandleSceneTicks.js';

export function PlotlyExpressChartPanel(props: WidgetPanelProps<Widget>) {
export function PlotlyExpressChartPanel(
props: WidgetPanelProps<Widget>
): JSX.Element {
const dh = useApi();
const { fetch, metadata = {}, ...rest } = props;
const containerRef = useRef<HTMLDivElement>(null);
Expand Down
Loading

0 comments on commit a4761cc

Please sign in to comment.