-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: make ui.panel flex align-items start by default (#604)
ui.panels implicitly wrap things in a flex, with a direction set to column. Column makes sense, as tables typically are wide, and stacking them makes more sense by default that side by side. However, a key distinction is with row, the horizonal axis alignment is equivalent to start. In column the horizonal axis (which is now a cross-axis) is stretch. I think we should set align-items: start for the implicit ui.flex column wrapper of ui.panel so that it doesn't stretch buttons in the horizontal cross-axis by default. before: ![image](https://github.com/deephaven/deephaven-plugins/assets/1576283/8efc1b3a-0d6b-45ef-9f72-bdf9d73f43b9) after: ![image_720](https://github.com/deephaven/deephaven-plugins/assets/1576283/7ce32114-238d-4c86-9293-d2b8faa776dc) BREAKING CHANGE: `ui.panel` implicitly created flexbox `align-items` property is now set to `start` by default instead of `normal` (which is equivalent to `stretch`). This results in a more pleasing default layout, as buttons will no longer be stretched to the full panel width. You can match previous behavior by explicitly returning a ui.panel with `align-items="normal"` if required.
- Loading branch information
Showing
6 changed files
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.