Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js content should be in same package directory #139

Closed
devinrsmith opened this issue Nov 27, 2023 · 4 comments
Closed

Js content should be in same package directory #139

devinrsmith opened this issue Nov 27, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@devinrsmith
Copy link
Member

deephaven-plugin-plotly-express has demonstrated packaging js content within a wheel. Currently, this content lives sourced in its own directory from the root, /tmp/dpe/lib/python3.11/site-packages/js/plotly-express/. I would have expected this content to live in the same subdirectory as the python content itself; for example /tmp/dpe/lib64/python3.11/site-packages/deephaven/plot/express/js/.

@devinrsmith devinrsmith added the bug Something isn't working label Nov 27, 2023
@devinrsmith devinrsmith added this to the December 2023 milestone Nov 27, 2023
@mofojed
Copy link
Member

mofojed commented Nov 27, 2023

Yea that makes sense... perhaps it should be prefixed with an _ to denote that it is private, e.g. /tmp/dpe/lib64/python3.11/site-packages/deephaven/plot/express/_js/
Then upon install, how does the plugin manager know where to pull the js source from? How does it know it's at deephaven/plot/express directory? We have version = attr:deephaven.plot.express.__version__ in the setup.cfg, would we need something similar for the location of the js?

@mofojed mofojed assigned mofojed and unassigned jnumainville Nov 27, 2023
@devinrsmith
Copy link
Member Author

I added strawman of how I think this should work in deephaven/deephaven-core#2772 (comment)

@devinrsmith
Copy link
Member Author

Agreed, _ prefix is a good idea too.

@mofojed
Copy link
Member

mofojed commented Mar 18, 2024

Fixed with #361

@mofojed mofojed closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants