Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package JS with python for plugins #194

Closed
mofojed opened this issue Jan 3, 2024 · 0 comments · Fixed by #343
Closed

Package JS with python for plugins #194

mofojed opened this issue Jan 3, 2024 · 0 comments · Fixed by #343
Assignees
@jnumainville
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@mofojed
Copy link
Member

mofojed commented Jan 3, 2024 •
edited
Loading

Currently only plotly-express packages the JS with the plugin, and registers the JS from python. Switch matplotlib, deephaven.ui over to do that as well.

We should be able to also try and register, and if the JS plugin is already registered then just warn instead of throwing.

Related to #139
@mofojed mofojed added enhancement New feature or request triage labels Jan 3, 2024
@vbabich vbabich added this to the Backlog milestone Jan 9, 2024
@vbabich vbabich removed the triage label Jan 9, 2024
@mofojed mofojed mentioned this issue Feb 23, 2024
Closed
@mofojed mofojed assigned mofojed and jnumainville and unassigned mofojed Feb 23, 2024
@jnumainville jnumainville mentioned this issue Feb 29, 2024
Merged
jnumainville added a commit that referenced this issue Mar 6, 2024
@jnumainville
feat: Add utilities package (#331)
6a635b9 
Adds new utilities and packaging packages. These can be used for
cross-plugin functionality. The first versions have functions that make
it simpler to register js plugins.

Part of the work for #316 and #194 

After this is merged I will upload the initial versions to pypi, then
use that for the follow-up PR to fix the issues themselves.
@jnumainville jnumainville mentioned this issue Mar 6, 2024
Merged
jnumainville added a commit that referenced this issue Mar 14, 2024
@jnumainville @mofojed
feat: Package matplotlib and ui JS with wheel (#343)
7724e55 
Fixes #194, fixes #316 

Packages matplotlib and ui JS with wheel using new util packages. I also
took the opportunity to refactor those two a bit to match the plotly
express package by moving registration out of the `__init__.py` files.
Also refactored plotly express.

I've verified the installed wheels work properly with basic examples.


---------

Co-authored-by: Mike Bender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnumainville jnumainville

Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat: Package matplotlib and ui JS with wheel jnumainville/deephaven-plugins
3 participants
@vbabich @mofojed @jnumainville