Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextual_help prop on all components should accept string | contextual_help #733

Closed
dsmmcken opened this issue Aug 14, 2024 · 0 comments · Fixed by #817
Closed

contextual_help prop on all components should accept string | contextual_help #733

dsmmcken opened this issue Aug 14, 2024 · 0 comments · Fixed by #817
Assignees
@wusteven815
Labels
enhancement New feature or request
Milestone
September 2024

Comments

@dsmmcken
Copy link
Contributor

Many form components such as picker or text_field accept contextual_help as prop which takes a ui.contextual_help as it's child. I think we should also just accept a simple string and auto wrap it, similar to how we auto wrap stuff with ui.text.

That way I can easily pass a basic string.
@dsmmcken dsmmcken added enhancement New feature or request triage labels Aug 14, 2024
@vbabich vbabich changed the title context_help prop on all components should accept string | contextual_help contextual_help prop on all components should accept string | contextual_help Aug 14, 2024
@vbabich vbabich added this to the August 2024 milestone Aug 14, 2024
@vbabich vbabich removed the triage label Aug 14, 2024
@vbabich vbabich modified the milestones: August 2024, September 2024 Aug 14, 2024
@wusteven815 wusteven815 mentioned this issue Sep 10, 2024
Merged
@wusteven815 wusteven815 linked a pull request Sep 10, 2024 that will close this issue
feat: wrap contextual help if primitive #817
Merged
wusteven815 added a commit that referenced this issue Sep 13, 2024
@wusteven815 @vbabich
feat: wrap contextual help if primitive (#817)
7e51073 
- Adds #733 
- If the `contextualHelp` prop is a primitive, wrap it in
`ContextualHelp` and `Content`

---------

Co-authored-by: Vlad Babich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wusteven815 wusteven815

Labels
enhancement New feature or request
Projects
None yet
Milestone
September 2024
Development

Successfully merging a pull request may close this issue.

feat: wrap contextual help if primitive wusteven815/deephaven-plugins
3 participants
@dsmmcken @vbabich @wusteven815