Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrap contextual help if primitive #817

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: wrap contextual help if primitive #817

merged 2 commits into from
Sep 13, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Sep 10, 2024 •
edited
Loading

@wusteven815 wusteven815 self-assigned this Sep 10, 2024
@wusteven815 wusteven815 linked an issue Sep 10, 2024 that may be closed by this pull request
contextual_help prop on all components should accept string | contextual_help #733
Closed
@wusteven815 wusteven815 marked this pull request as ready for review September 10, 2024 19:59
@wusteven815 wusteven815 requested review from a team and vbabich and removed request for a team September 10, 2024 20:16
vbabich
vbabich previously requested changes Sep 11, 2024
View reviewed changes
plugins/ui/src/js/src/widget/WidgetUtils.tsx Outdated Show resolved Hide resolved
@wusteven815 wusteven815 requested a review from vbabich September 12, 2024 17:56
@wusteven815 wusteven815 merged commit 7e51073 into deephaven:main Sep 13, 2024
16 checks passed
@wusteven815 wusteven815 deleted the 733-auto-wrap-contextual-help branch September 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbabich vbabich vbabich approved these changes

Assignees

@wusteven815 wusteven815

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contextual_help prop on all components should accept string | contextual_help
2 participants
@wusteven815 @vbabich