Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui.labeled_value #1029

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: ui.labeled_value #1029

wants to merge 15 commits into from

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Nov 20, 2024 •
edited by mofojed
Loading

Closes #938 and Closes #869 and closes DH-18132.

Additional Notes:

  • After conversation with @mofojed yesterday, I will be creating separate PR to implement the ability to pass in dates and have date formatting (given that it will require a fair share of logic)
  • Have put up this PR in the interim so that docs and the other functionality can be reviewed

@AkshatJawne AkshatJawne self-assigned this Nov 20, 2024
mofojed
mofojed requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an e2e test as well

plugins/ui/docs/components/labeled_value.md Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/labeled_value.py Outdated Show resolved Hide resolved
@AkshatJawne AkshatJawne requested a review from mofojed November 22, 2024 18:20
@AkshatJawne AkshatJawne requested a review from mofojed November 26, 2024 22:12
mofojed
mofojed previously approved these changes Nov 27, 2024
View reviewed changes
margaretkennedy
margaretkennedy reviewed Nov 27, 2024
View reviewed changes
plugins/ui/docs/components/labeled_value.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/labeled_value.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/labeled_value.md Outdated Show resolved Hide resolved
dsmmcken
dsmmcken previously approved these changes Nov 29, 2024
View reviewed changes
dsmmcken
dsmmcken previously approved these changes Dec 4, 2024
View reviewed changes
margaretkennedy
margaretkennedy previously approved these changes Dec 4, 2024
View reviewed changes
@AkshatJawne AkshatJawne dismissed stale reviews from margaretkennedy and dsmmcken via 3d0729c December 5, 2024 16:32
mofojed
mofojed requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just merge in the latest main, should have those snapshots updated already.

tests/express.spec.ts-snapshots/Histogram-loads-1-webkit-linux.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this snapshot updated. ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed requested changes

@margaretkennedy margaretkennedy margaretkennedy left review comments

@dsmmcken dsmmcken dsmmcken left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@AkshatJawne AkshatJawne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.labeled_value docs: ui.labeled_value
4 participants
@AkshatJawne @dsmmcken @mofojed @margaretkennedy