docs: Menu and MenuTrigger Docs #1051
Conversation
dgodinez-dh
requested review from
a team and
wusteven815
and removed request for
a team
dgodinez-dh
changed the title
wusteven815
requested review from
mofojed
and removed request for
wusteven815
| _table = new_table( | ||
| [ | ||
| string_col("Keys", ["key-0", "key-1", "key-2"]), | ||
| string_col("Labels", ["Option 0", "Option 1", "Option 2"]), | ||
| ] | ||
| ) | ||
|
|
There was a problem hiding this comment.
Would be cool to show use with a ticking table as well.
There was a problem hiding this comment.
Would we really want to use a ticking table as item source for a menu? I suppose it would work, but I dislike the idea of menu items appearing / disappearing as the table ticks. Also, what would happen if the menu was open while the table ticked? Does it update, or is the menu now out of date?
There was a problem hiding this comment.
Guess we should clarify the behaviour with @dsmmcken , but I see a few possible options when the table ticks while the menu is open (ordered by my preference):
- Update the menu in place. Seems this is what Spectrum will do by default: https://codesandbox.io/p/sandbox/react-spectrum-playground-forked-rfctrs
- Dismiss the menu. They need to re-open the menu.
- Freeze the items in the menu while it's open. Could mean some actions are out of date and will error when selected.
We definitely need to decide on what to do with a ticking table... and if you're hooking up a ticking table to a menu, I imagine having it update in place is acceptable.
There was a problem hiding this comment.
Spun this off into another ticket:
https://deephaven.atlassian.net/browse/DH-18305
Going to remove this section from the doc for now.
Co-authored-by: Mike Bender <[email protected]>
Jira ticket: https://deephaven.atlassian.net/browse/DH-18089