Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Render Lists #1061

Merged
merged 13 commits into from
Dec 20, 2024
Merged

docs: Render Lists #1061

merged 13 commits into from
Dec 20, 2024

Conversation

dgodinez-dh
Copy link
Contributor

@dgodinez-dh dgodinez-dh commented Dec 12, 2024

@dgodinez-dh dgodinez-dh requested a review from mofojed December 13, 2024 16:38
plugins/ui/docs/describing/render_lists.md Outdated Show resolved Hide resolved
plugins/ui/docs/describing/render_lists.md Outdated Show resolved Hide resolved
plugins/ui/docs/describing/render_lists.md Outdated Show resolved Hide resolved
on_press=lambda: delete_cell(i),
),
align_items="end",
# comment in this line to fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "comment in" make sense? I guess it would be opposite of "comment out". I don't think I've ever heard the phrase though. More familiar with "uncomment", your discretion.

Suggested change
# comment in this line to fix
# uncomment this line to fix

plugins/ui/docs/describing/render_lists.md Outdated Show resolved Hide resolved
@dgodinez-dh dgodinez-dh requested a review from mofojed December 20, 2024 13:56
@dgodinez-dh dgodinez-dh merged commit 30a1f9f into deephaven:main Dec 20, 2024
18 checks passed
@dgodinez-dh dgodinez-dh deleted the dag_RenderLists branch January 2, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants