Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui.table functionality #145

Merged
merged 16 commits into from
Jan 4, 2024
Merged

feat: ui.table functionality #145

merged 16 commits into from
Jan 4, 2024

Conversation

jnumainville
Copy link
Collaborator

@jnumainville jnumainville commented Nov 30, 2023

This is not ready for review but I am putting this up just in case as I know Bender mentioned possibly working on some of the js functionality while I am on vacation. What's implemented is not thoroughly tested, needs to be refactored, and subject to change but I have sorts, quick filters, and the search bar hooked up.

Example:

from deephaven import SortDirection
import deephaven.ui as ui
import deephaven.plot.express as dx

stocks = dx.data.stocks()

@ui.component
def searchable_filtered_sorted_table(source):
    return [
        ui.panel(
            ui.table(source)
            .sort("price", SortDirection.DESCENDING)
            .quick_filter({"side": "sell"})
            .can_search("SHOW"),
            title="Stock Table I",
        )
    ]


sti = searchable_filtered_sorted_table(stocks)

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run eslint as well

plugins/ui/src/deephaven/ui/elements/UITable.py Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/elements/types.py Outdated Show resolved Hide resolved
@jnumainville
Copy link
Collaborator Author

I was mostly able to merge the refactors in, but for some reason the quick filters are not coming through. Still investigating.

@jnumainville jnumainville marked this pull request as ready for review January 2, 2024 15:00
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor cleanups

plugins/ui/src/deephaven/ui/elements/UITable.py Outdated Show resolved Hide resolved
plugins/ui/src/js/src/UITable.tsx Outdated Show resolved Hide resolved
@jnumainville
Copy link
Collaborator Author

jnumainville commented Jan 3, 2024

@mofojed I still can't seem to get quick filters appearing after the refactor. Any ideas? It seems like the same exact quickFilters prop is being passed to the IrisGrid

@jnumainville jnumainville requested a review from mofojed January 4, 2024 21:30
@mofojed mofojed merged commit df04f29 into deephaven:main Jan 4, 2024
11 checks passed
@mofojed mofojed mentioned this pull request Jan 9, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants