Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Script for creating new theme plugin #154

Closed

Conversation

bmingles
Copy link
Contributor

Added a script for creating new theme plugin. See README for instructions.

@bmingles bmingles marked this pull request as draft December 11, 2023 18:38
@bmingles bmingles force-pushed the 153-document-theme-plugin-dev branch from bf794f7 to ae496e2 Compare December 12, 2023 21:58
@mofojed
Copy link
Member

mofojed commented Dec 14, 2023

Documenting what we discussed in our 1:1 here.
I want to take a look at using something like cookiecutter (doesn't necessarily have to be that package) for making a template. We publish a package that you can use to create a template, e.g. npx @deephaven/create-plugin, and then we can have templates for Theme plugins, or any other type of plugin.
Seems like the best option because it doesn't require cloning a repo to run a script.
Of course when we have python packaging up our JS plugins, we may want to use a more powerful templater (like yeoman or cookiecutter).
I just think we can do better than requiring someone clone our repo.

@bmingles
Copy link
Contributor Author

bmingles commented Feb 6, 2024

Will be addressed by #256

@bmingles bmingles closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants