-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add cocogitto/release.sh to perform releases. #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running this bump.sh script on Mac, and it doesn't seem to work. The first time I ran it, it asked to install Cocogitto (good). I installed, then I ran again and it just shows a screen:
![image](https://private-user-images.githubusercontent.com/4505624/297130884-747d206d-503d-47ed-b9fb-b728a4d2bd5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NDQzMDUsIm5iZiI6MTczODg0NDAwNSwicGF0aCI6Ii80NTA1NjI0LzI5NzEzMDg4NC03NDdkMjA2ZC01MDNkLTQ3ZWQtYjlmYi1iNzI4YTRkMmJkNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTIxMzI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWIzNjQxZTM5ZTNkNzQ4ZGUyZTk0ZjBjMWMxZGZhMGUwZTA2YzIzMTA4Y2ZjYTcwMTllMzViYWYzNmRmOThlNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.NLarJww1FeoNzEXTKm2zLbz5odZm9QZI4f0v4MuRb5s)
I then don't know what to press? I tried press Enter, does nothing; I hit "Q" and then I just get the following output:
![image](https://private-user-images.githubusercontent.com/4505624/297130792-d19388cb-5a58-4117-bc5b-b96da021dc4a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NDQzMDUsIm5iZiI6MTczODg0NDAwNSwicGF0aCI6Ii80NTA1NjI0LzI5NzEzMDc5Mi1kMTkzODhjYi01YTU4LTQxMTctYmM1Yi1iOTZkYTAyMWRjNGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTIxMzI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmUxY2FiMDIwYTY3ZDBjYjYzYTI4ZjBjODAxNWIwNTY2YTg3ZGY4YWUzOTUxM2NkZTZhOGM3NjUxNzNlZDVhMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Fj_37X0tyhaqfcAshRd3yUVuRyG_aUvXED8uakQ303c)
Also we should update the root level README with instructions on running the version bump for releases. |
34f225d
to
232579b
Compare
232579b
to
81c1607
Compare
Try again w/ the latest. If you set your git remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's close! Getting an error on mac with the sed step:
(.venv) ➜ deephaven-plugins git:(main) ./tools/release.sh -d ui
+ shift
+ (( 1 > 0 ))
+ case "$1" in
+ '[' -n '' ']'
+ grep -q ui
+ package=ui
+ shift
+ (( 0 > 0 ))
+ '[' -z ui ']'
+ grep -q plugins/ui /Users/bender/dev/deephaven/oss/deephaven-plugins/cog.toml
bender - 2024-01-19 10:06:04 |--- Releasing package 'ui'
+ cd /Users/bender/dev/deephaven/oss/deephaven-plugins
+ cog bump --package ui --auto
Found bug fix commit 0533cd
[pre-bump-ui]
[echo Updating ui to version 0.1.1]
Updating ui to version 0.1.1
[../../tools/update_version.sh ui 0.1.1]
sed: 1: "/Users/bender/dev/deeph ...": undefined label 'ender/dev/deephaven/oss/deephaven-plugins/plugins/ui/src/deephaven/ui/__init__.py'
Error: prehook run `../../tools/update_version.sh ui 0.1.1` failed
All changes made during hook runs have been stashed on `cog_bump_ui-v0.1.1`
you can run `git stash apply stash@0` to restore these changes.
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! One minor change to the TODO (need to have an associated ticket for TODOs).
Also for posterity I don't know why I need to press Q when doing a release to advance. Seems odd, and I'll probably dig into that at some point.
Fixes #218 |
Fixes #213
Fixes #218