Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add cocogitto/release.sh to perform releases. #206

Merged
merged 46 commits into from
Jan 20, 2024
Merged

Conversation

JamesXNelson
Copy link
Member

@JamesXNelson JamesXNelson commented Jan 13, 2024

Fixes #213
Fixes #218

  • Add cog.toml to configure cocogitto, which generates changelogs and version tags
  • Add tools/release.sh to perform a complete version bump + changelog update and github release for a plugin
  • Updated README.md with instructions regarding the release process

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this bump.sh script on Mac, and it doesn't seem to work. The first time I ran it, it asked to install Cocogitto (good). I installed, then I ran again and it just shows a screen:

image

I then don't know what to press? I tried press Enter, does nothing; I hit "Q" and then I just get the following output:

image

bump.sh Outdated Show resolved Hide resolved
releases/README.md Outdated Show resolved Hide resolved
cog.toml Show resolved Hide resolved
cog.toml Outdated Show resolved Hide resolved
@mofojed
Copy link
Member

mofojed commented Jan 16, 2024

Also we should update the root level README with instructions on running the version bump for releases.

cog.toml Outdated Show resolved Hide resolved
bump.sh Outdated Show resolved Hide resolved
@JamesXNelson JamesXNelson force-pushed the jxn/cocogitto branch 2 times, most recently from 34f225d to 232579b Compare January 19, 2024 09:39
@JamesXNelson JamesXNelson changed the title Add cocogitto/bump.sh to perform releases ci: Add cocogitto/bump.sh to perform releases Jan 19, 2024
@JamesXNelson
Copy link
Member Author

I tried running this bump.sh script on Mac, and it doesn't seem to work. The first time I ran it, it asked to install Cocogitto (good). I installed, then I ran again and it just shows a screen:

Try again w/ the latest. If you set your git remote origin to your fork, you can safely push test releases there.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's close! Getting an error on mac with the sed step:

(.venv) ➜  deephaven-plugins git:(main) ./tools/release.sh -d ui            
+ shift
+ ((  1 > 0  ))
+ case "$1" in
+ '[' -n '' ']'
+ grep -q ui
+ package=ui
+ shift
+ ((  0 > 0  ))
+ '[' -z ui ']'
+ grep -q plugins/ui /Users/bender/dev/deephaven/oss/deephaven-plugins/cog.toml
bender   -  2024-01-19 10:06:04  |--- Releasing package 'ui'
+ cd /Users/bender/dev/deephaven/oss/deephaven-plugins
+ cog bump --package ui --auto
        Found bug fix commit 0533cd
[pre-bump-ui]
[echo Updating ui to version 0.1.1]
Updating ui to version 0.1.1

[../../tools/update_version.sh ui 0.1.1]
sed: 1: "/Users/bender/dev/deeph ...": undefined label 'ender/dev/deephaven/oss/deephaven-plugins/plugins/ui/src/deephaven/ui/__init__.py'
Error: prehook run `../../tools/update_version.sh ui 0.1.1` failed
        All changes made during hook runs have been stashed on `cog_bump_ui-v0.1.1`
        you can run `git stash apply stash@0` to restore these changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tools/update_version.sh Outdated Show resolved Hide resolved
tools/update_version.sh Show resolved Hide resolved
tools/update_version.sh Outdated Show resolved Hide resolved
tools/release.sh Outdated Show resolved Hide resolved
cog.toml Outdated Show resolved Hide resolved
tools/update_version.sh Show resolved Hide resolved
JamesXNelson and others added 10 commits January 19, 2024 12:37
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
Co-authored-by: Mike Bender <[email protected]>
tools/validate.sh Outdated Show resolved Hide resolved
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! One minor change to the TODO (need to have an associated ticket for TODOs).

Also for posterity I don't know why I need to press Q when doing a release to advance. Seems odd, and I'll probably dig into that at some point.

cog.toml Outdated Show resolved Hide resolved
@JamesXNelson
Copy link
Member Author

Fixes #218

@JamesXNelson JamesXNelson changed the title ci: Add cocogitto/bump.sh to perform releases ci: Add cocogitto/release.sh to perform releases. Jan 20, 2024
@mofojed mofojed merged commit 63945e7 into main Jan 20, 2024
13 checks passed
@mofojed mofojed deleted the jxn/cocogitto branch January 20, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants